Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1576503002: Add test showing broken-ness of non-simple parameter named 'arguments' (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test showing broken-ness of non-simple parameter named 'arguments' This at least puts something in the tree demonstrating the breakage; it can be moved into regress/ if we fix it. R=littledan@chromium.org BUG=v8:4577 LOG=n Committed: https://crrev.com/067c27be652c760a1b0a072380ade4dfdce5ea31 Cr-Commit-Position: refs/heads/master@{#33193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
A + test/mjsunit/bugs/bug-4577.js View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
adamk
4 years, 11 months ago (2016-01-08 19:40:50 UTC) #1
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-08 20:05:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576503002/1
4 years, 11 months ago (2016-01-08 20:05:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 20:28:58 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:29:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/067c27be652c760a1b0a072380ade4dfdce5ea31
Cr-Commit-Position: refs/heads/master@{#33193}

Powered by Google App Engine
This is Rietveld 408576698