Chromium Code Reviews

Unified Diff: build/android/pylib/gtest/gtest_test_instance.py

Issue 1576473002: Android gtest runner: Only query device for test list when necessary (take 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: alphebetize a couple things Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: build/android/pylib/gtest/gtest_test_instance.py
diff --git a/build/android/pylib/gtest/gtest_test_instance.py b/build/android/pylib/gtest/gtest_test_instance.py
index 4250ea3ddd4eeb7ffd0f37647eb9399a4e07ffcb..a9d061d64a2735cd6de2d037e920903a9b5e4e97 100644
--- a/build/android/pylib/gtest/gtest_test_instance.py
+++ b/build/android/pylib/gtest/gtest_test_instance.py
@@ -134,9 +134,9 @@ class GtestTestInstance(test_instance.TestInstance):
# TODO(jbudorick): Support multiple test suites.
if len(args.suite_name) > 1:
raise ValueError('Platform mode currently supports only 1 gtest suite')
- self._suite = args.suite_name[0]
-
+ self._extract_test_list_from_filter = args.extract_test_list_from_filter
self._shard_timeout = args.shard_timeout
+ self._suite = args.suite_name[0]
incremental_part = '_incremental' if args.incremental_install else ''
apk_path = os.path.join(
@@ -256,6 +256,10 @@ class GtestTestInstance(test_instance.TestInstance):
def test_arguments(self):
return self._test_arguments
+ @property
+ def extract_test_list_from_filter(self):
+ return self._extract_test_list_from_filter
+
#override
def TestType(self):
return 'gtest'
« no previous file with comments | « no previous file | build/android/pylib/local/device/local_device_gtest_run.py » ('j') | build/android/test_runner.py » ('J')

Powered by Google App Engine