fix opacity check in SkBitmapDevice::Create

fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1576453002

Committed: https://skia.googlesource.com/skia/+/04d975ac34c97d4869f819d2ad7c9fda47c198af

[lsalzman1, 2016-01-08 18:56:12]

Description was changed from

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
==========

to

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[lsalzman1, 2016-01-08 18:56:59]

Description was changed from

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[lsalzman1, 2016-01-08 18:56:59]

lsalzman@mozilla.com changed reviewers:
+ mtklein@google.com

[lsalzman1, 2016-01-08 18:57:46]

This ensures the correct SkImageInfo is used to check for opacity in
SkBitmapDevice::Create().

[mtklein, 2016-01-08 19:01:41]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-01-08 19:01:42]

lgtm

[commit-bot: I haz the power, 2016-01-08 19:01:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576453002/1

[commit-bot: I haz the power, 2016-01-08 19:20:15]

Description was changed from

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix opacity check in SkBitmapDevice::Create

BUG=skia:4777
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/04d975ac34c97d4869f819d2ad7c9fda47c198af
==========

[commit-bot: I haz the power, 2016-01-08 19:20:16]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/04d975ac34c97d4869f819d2ad7c9fda47c198af

[reed1, 2016-01-08 19:38:05]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-01-08 19:38:05]

yikes, but a stupid bug (mine). Good catch.

[mtklein, 2016-01-08 19:40:59]

On 2016/01/08 19:38:05, reed1 wrote:
> yikes, but a stupid bug (mine). Good catch.

Don't feel bad.  It was my stupid bug.  When you wrote bitmap.info().isOpaque()
it was correct (as would have info.isOpaque() been too).