Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1576423005: Revert of Fix null dereference on MemoryCache. (Closed)

Created:
4 years, 11 months ago by yhirano
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Revert of Fix null dereference on MemoryCache. (patchset #1 id:1 of https://codereview.chromium.org/1576113006/ ) Reason for revert: The change broke beta builds. Original issue's description: > Fix null dereference on MemoryCache. > > Usually a valid MemoryCacheEntry holds a non-null Resource as |m_resource|. But > when we hold a valid MemoryCacheEntry beyond destructive statements, it may be > evicted from the cache and get stale. That means |m_resource| can be null in > such cases. This CL checks it in order to avoid null dereference. > > BUG=488373 > > Review URL: https://codereview.chromium.org/1537343002 > > Cr-Commit-Position: refs/heads/master@{#367802} > (cherry picked from commit 843010ff7eeda6e9e87347aaaa6365efecd1161d) > > Committed: https://chromium.googlesource.com/chromium/src/+/9f80eae6508185f7aed39f1f91a301d9ca18978a TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488373

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
yhirano
Created Revert of Fix null dereference on MemoryCache.
4 years, 11 months ago (2016-01-13 02:16:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423005/1
4 years, 11 months ago (2016-01-13 02:18:23 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 02:21:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698