Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1576423004: Remove -Wno-shift-op-parentheses for fusl build (Closed)

Created:
4 years, 11 months ago by kulakowski
Modified:
4 years, 11 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M fusl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M fusl/include/byteswap.h View 1 chunk +1 line, -1 line 0 comments Download
M fusl/include/endian.h View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/locale/iconv.c View 3 chunks +3 lines, -3 lines 0 comments Download
M fusl/src/malloc/malloc.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/multibyte/c16rtomb.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/prng/__rand48_step.c View 1 chunk +2 lines, -2 lines 0 comments Download
M fusl/src/stdio/vfprintf.c View 1 2 chunks +8 lines, -8 lines 0 comments Download
M fusl/src/stdio/vfwprintf.c View 1 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kulakowski
4 years, 11 months ago (2016-01-12 18:11:39 UTC) #1
viettrungluu
lgtm w/optional nits https://codereview.chromium.org/1576423004/diff/1/fusl/src/malloc/malloc.c File fusl/src/malloc/malloc.c (right): https://codereview.chromium.org/1576423004/diff/1/fusl/src/malloc/malloc.c#newcode126 fusl/src/malloc/malloc.c:126: return (((union { float v; uint32_t ...
4 years, 11 months ago (2016-01-12 18:40:02 UTC) #2
kulakowski
https://codereview.chromium.org/1576423004/diff/1/fusl/src/stdio/vfprintf.c File fusl/src/stdio/vfprintf.c (right): https://codereview.chromium.org/1576423004/diff/1/fusl/src/stdio/vfprintf.c#newcode488 fusl/src/stdio/vfprintf.c:488: for (fl=0; (unsigned)*s-' '<32 && (FLAGMASK&(1U<<(*s-' ')));s++) On 2016/01/12 ...
4 years, 11 months ago (2016-01-12 19:50:25 UTC) #3
kulakowski
4 years, 11 months ago (2016-01-12 19:51:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bbd6acf5f061594f91e9034a76a4ad7990d31f62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698