Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1576423003: Fix the receiver check in the HandleFastApiCall builtin. (Closed)

Created:
4 years, 11 months ago by epertoso
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the receiver check in the HandleFastApiCall builtin. CompatibleReceiverCheck used by the HandleFastApiCall builtin was terminating with failure upon encountering a hidden prototype. It should actually stop iterating on the first non-hidden prototype. BUG= Committed: https://crrev.com/71129d5b4323902ab9702ae3e5e123b3c59d5dfd Cr-Commit-Position: refs/heads/master@{#33294}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -69 lines) Patch
M src/arm/builtins-arm.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-receiver-check-hidden-prototype.cc View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
epertoso
4 years, 11 months ago (2016-01-12 16:44:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423003/1
4 years, 11 months ago (2016-01-12 16:44:13 UTC) #6
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 11 months ago (2016-01-12 16:44:17 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423003/1
4 years, 11 months ago (2016-01-12 16:46:13 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12289)
4 years, 11 months ago (2016-01-12 17:53:59 UTC) #12
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-13 05:34:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423003/1
4 years, 11 months ago (2016-01-13 09:11:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/13893)
4 years, 11 months ago (2016-01-13 09:48:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423003/1
4 years, 11 months ago (2016-01-13 10:07:12 UTC) #19
Michael Achenbach
Please fix the CL description. First line becomes the commit message and should be equal ...
4 years, 11 months ago (2016-01-13 10:39:02 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/13897)
4 years, 11 months ago (2016-01-13 10:42:55 UTC) #22
epertoso
On 2016/01/13 at 10:39:02, machenbach wrote: > Please fix the CL description. First line becomes ...
4 years, 11 months ago (2016-01-13 11:10:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576423003/20001
4 years, 11 months ago (2016-01-14 11:50:38 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 12:23:46 UTC) #28
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 12:24:12 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71129d5b4323902ab9702ae3e5e123b3c59d5dfd
Cr-Commit-Position: refs/heads/master@{#33294}

Powered by Google App Engine
This is Rietveld 408576698