Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1576403002: Reland [arm64] Improve some new builtins. (Closed)

Created:
4 years, 11 months ago by jbramley
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [arm64] Improve some new builtins. - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. BUG= Committed: https://crrev.com/a1103a117c7fcd5484251336ac9f89ccafefa62f Cr-Commit-Position: refs/heads/master@{#33235}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -152 lines) Patch
M src/arm64/builtins-arm64.cc View 8 chunks +214 lines, -152 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 7 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
jbramley
Originally reviewed here: https://codereview.chromium.org/1537903004/ I had to change the argument handling mechanisms so that they ...
4 years, 11 months ago (2016-01-12 10:45:30 UTC) #2
jbramley
https://codereview.chromium.org/1576403002/diff/1/src/full-codegen/arm64/full-codegen-arm64.cc File src/full-codegen/arm64/full-codegen-arm64.cc (right): https://codereview.chromium.org/1576403002/diff/1/src/full-codegen/arm64/full-codegen-arm64.cc#newcode2443 src/full-codegen/arm64/full-codegen-arm64.cc:2443: ASM_LOCATION("FullCodeGenerator::EmitCallWithLoadIC"); I added these whilst debugging. Several of the ...
4 years, 11 months ago (2016-01-12 10:47:12 UTC) #3
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-12 11:19:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576403002/1
4 years, 11 months ago (2016-01-12 11:20:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 11:57:11 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 11:58:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1103a117c7fcd5484251336ac9f89ccafefa62f
Cr-Commit-Position: refs/heads/master@{#33235}

Powered by Google App Engine
This is Rietveld 408576698