DevTools: show extension name in console context switcher

Source/bindings/v8/DOMWrapperWorld.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 151 matching lines @@
 }
 
 typedef HashMap<int, RefPtr<SecurityOrigin> > IsolatedWorldSecurityOriginMap;
 static IsolatedWorldSecurityOriginMap& isolatedWorldSecurityOrigins()
 {
     ASSERT(isMainThread());
     DEFINE_STATIC_LOCAL(IsolatedWorldSecurityOriginMap, map, ());
     return map;
 }
 
+typedef HashMap<int, String> IsolatedWorldHumanReadableNameMap;
+static IsolatedWorldHumanReadableNameMap& isolatedWorldHumanReadableNames()
+{
+    ASSERT(isMainThread());
+    DEFINE_STATIC_LOCAL(IsolatedWorldHumanReadableNameMap, map, ());

[pfeldman, 2013/08/05 16:44:49]

You should not create yet another map, we can extend existing one to store more
bits associated with the world. It is also worth checking if the lazy binding is
already fixed so that you could simply make it a field of the world. See
https://bugs.webkit.org/show_bug.cgi?id=97398 and talk to Dan.

[lushnikov, 2014/08/23 20:37:46]

So I've got to create this map due to the fact that the world is reported in
inspector instrumentation at the moment of its creation, deeper in stack. That
means that the humanReadableName should be preset before the actual world
creation.

The same thing actually happens with other two maps here.

+    return map;
+}
+
 SecurityOrigin* DOMWrapperWorld::isolatedWorldSecurityOrigin()
 {
     ASSERT(this->isIsolatedWorld());
     IsolatedWorldSecurityOriginMap& origins = isolatedWorldSecurityOrigins();
     IsolatedWorldSecurityOriginMap::iterator it = origins.find(worldId());
     return it == origins.end() ? 0 : it->value.get();
 }
 
 void DOMWrapperWorld::setIsolatedWorldSecurityOrigin(int worldID, PassRefPtr<SecurityOrigin> securityOrigin)
 {
     ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
     if (securityOrigin)
         isolatedWorldSecurityOrigins().set(worldID, securityOrigin);
     else
         isolatedWorldSecurityOrigins().remove(worldID);
 }
 
+void DOMWrapperWorld::setIsolatedWorldHumanReadableName(int worldID, const String& humanReadableName)
+{
+    ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
+    if (!humanReadableName.isEmpty())
+        isolatedWorldHumanReadableNames().set(worldID, humanReadableName);
+    else
+        isolatedWorldHumanReadableNames().remove(worldID);
+}
+
+String DOMWrapperWorld::isolatedWorldHumanReadableName()
+{
+    ASSERT(this->isIsolatedWorld());
+    IsolatedWorldHumanReadableNameMap& humanReadableNames = isolatedWorldHumanReadableNames();
+    IsolatedWorldHumanReadableNameMap::iterator it = humanReadableNames.find(worldId());
+    return it == humanReadableNames.end() ? "" : it->value;
+}
+
 void DOMWrapperWorld::clearIsolatedWorldSecurityOrigin(int worldID)
 {
     ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
     isolatedWorldSecurityOrigins().remove(worldID);
 }
 
 typedef HashMap<int, bool> IsolatedWorldContentSecurityPolicyMap;
 static IsolatedWorldContentSecurityPolicyMap& isolatedWorldContentSecurityPolicies()
 {
     ASSERT(isMainThread());
@@ skipping 38 matching lines @@
 } 
 
 V8DOMActivityLogger* DOMWrapperWorld::activityLogger(int worldId)
 {
     DOMActivityLoggerMap& loggers = domActivityLoggers();
     DOMActivityLoggerMap::iterator it = loggers.find(worldId);   
     return it == loggers.end() ? 0 : it->value.get();
 } 
 
 } // namespace WebCore