DevTools: show extension name in console context switcher

Source/bindings/v8/DOMWrapperWorld.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 151 matching lines @@
 }
 
 typedef HashMap<int, RefPtr<SecurityOrigin> > IsolatedWorldSecurityOriginMap;
 static IsolatedWorldSecurityOriginMap& isolatedWorldSecurityOrigins()
 {
     ASSERT(isMainThread());
     DEFINE_STATIC_LOCAL(IsolatedWorldSecurityOriginMap, map, ());
     return map;
 }
 
+typedef HashMap<int, String> IsolatedWorldHumanReadableNameMap;
+static IsolatedWorldHumanReadableNameMap& isolatedWorldHumanReadableNames()
+{
+    ASSERT(isMainThread());
+    DEFINE_STATIC_LOCAL(IsolatedWorldHumanReadableNameMap, map, ());
+    return map;
+}
+
 SecurityOrigin* DOMWrapperWorld::isolatedWorldSecurityOrigin()
 {
     ASSERT(this->isIsolatedWorld());
     IsolatedWorldSecurityOriginMap& origins = isolatedWorldSecurityOrigins();
     IsolatedWorldSecurityOriginMap::iterator it = origins.find(worldId());
     return it == origins.end() ? 0 : it->value.get();
 }
 
 void DOMWrapperWorld::setIsolatedWorldSecurityOrigin(int worldID, PassRefPtr<SecurityOrigin> securityOrigin)
 {
     ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
     if (securityOrigin)
         isolatedWorldSecurityOrigins().set(worldID, securityOrigin);
     else
         isolatedWorldSecurityOrigins().remove(worldID);
 }
 
+void DOMWrapperWorld::setIsolatedWorldHumanReadableName(int worldID, const String& humanReadableName)
+{
+    ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
+    if (!humanReadableName.isEmpty())
+        isolatedWorldHumanReadableNames().set(worldID, humanReadableName);
+    else
+        isolatedWorldHumanReadableNames().remove(worldID);
+}
+
+String DOMWrapperWorld::isolatedWorldHumanReadableName()
+{
+    ASSERT(this->isIsolatedWorld());
+    IsolatedWorldHumanReadableNameMap& humanReadableNames = isolatedWorldHumanReadableNames();
+    IsolatedWorldHumanReadableNameMap::iterator it = humanReadableNames.find(worldId());

[yurys, 2013/05/24 04:58:44]

Hm, why does DOMWrapperWorld use several static storages to map world id to one
of the worlds properties instead of having single maps world id ->
DOMWrapperWorld and storing all properties on the object? In this particular
case human readable name looks like a natural field on DOMWrapperWorld.

+    return it == humanReadableNames.end() ? "" : it->value;
+}
+
 void DOMWrapperWorld::clearIsolatedWorldSecurityOrigin(int worldID)
 {
     ASSERT(DOMWrapperWorld::isIsolatedWorldId(worldID));
     isolatedWorldSecurityOrigins().remove(worldID);
 }
 
 typedef HashMap<int, bool> IsolatedWorldContentSecurityPolicyMap;
 static IsolatedWorldContentSecurityPolicyMap& isolatedWorldContentSecurityPolicies()
 {
     ASSERT(isMainThread());
@@ skipping 38 matching lines @@
 } 
 
 V8DOMActivityLogger* DOMWrapperWorld::activityLogger(int worldId)
 {
     DOMActivityLoggerMap& loggers = domActivityLoggers();
     DOMActivityLoggerMap::iterator it = loggers.find(worldId);   
     return it == loggers.end() ? 0 : it->value.get();
 } 
 
 } // namespace WebCore