Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: tests/lib/async/catch_errors9_test.dart

Issue 15764003: Add Zone support for Timers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/async/catch_errors8_test.dart ('k') | tests/lib/async/catch_errors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/catch_errors9_test.dart
diff --git a/tests/lib/async/catch_errors2_test.dart b/tests/lib/async/catch_errors9_test.dart
similarity index 74%
copy from tests/lib/async/catch_errors2_test.dart
copy to tests/lib/async/catch_errors9_test.dart
index e67d665019b5f67e1f5f77fc268d5fb4501526fa..e3413af827a233706ed5b9dea8224e2a4a378cc7 100644
--- a/tests/lib/async/catch_errors2_test.dart
+++ b/tests/lib/async/catch_errors9_test.dart
@@ -8,18 +8,18 @@ import 'dart:isolate';
main() {
// We keep a ReceivePort open until all tests are done. This way the VM will
- // time out if the callbacks are not invoked.
+ // hang if the callbacks are not invoked and the test will time out.
var port = new ReceivePort();
bool futureWasExecuted = false;
- // Make sure that `catchErrors` only closes the error stream when the inner
- // futures are done.
+ // Test that `catchErrors` waits for `Timer.run` before closing its error
+ // stream.
catchErrors(() {
- new Future(() {
+ Timer.run(() {
futureWasExecuted = true;
});
return 'allDone';
}).listen((x) {
- Expect.fail("Unexped callback");
+ Expect.fail("Unexpected callback");
},
onDone: () {
Expect.isTrue(futureWasExecuted);
« no previous file with comments | « tests/lib/async/catch_errors8_test.dart ('k') | tests/lib/async/catch_errors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698