Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: sdk/lib/async/timer.dart

Issue 15764003: Add Zone support for Timers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix bug and add tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/async/timer.dart
diff --git a/sdk/lib/async/timer.dart b/sdk/lib/async/timer.dart
index bfa7ced29b445ca1f0dba4f742b1a339203b8282..3544728ece9ad5f242f97da7d80a2104ca8e89a9 100644
--- a/sdk/lib/async/timer.dart
+++ b/sdk/lib/async/timer.dart
@@ -29,7 +29,9 @@ abstract class Timer {
* Note: If Dart code using Timer is compiled to JavaScript, the finest
* granularity available in the browser is 4 milliseconds.
*/
- external factory Timer(Duration duration, void callback());
+ factory Timer(Duration duration, void callback()) {
+ return _Zone.current.createTimer(duration, callback);
+ }
/**
* Creates a new repeating timer.
@@ -37,8 +39,10 @@ abstract class Timer {
* The [callback] is invoked repeatedly with [duration] intervals until
* canceled. A negative duration is treated similar to a duration of 0.
*/
- external factory Timer.periodic(Duration duration,
- void callback(Timer timer));
+ factory Timer.periodic(Duration duration,
+ void callback(Timer timer)) {
+ return _Zone.current.createPeriodicTimer(duration, callback);
+ }
/**
* Runs the given [callback] asynchronously as soon as possible.
@@ -54,3 +58,7 @@ abstract class Timer {
*/
void cancel();
}
+
+external Timer _createTimer(Duration duration, void callback());
+external Timer _createPeriodicTimer(Duration duration,
+ void callback(Timer timer));

Powered by Google App Engine
This is Rietveld 408576698