Add tests for binary_tools functions

Add tests for binary_tools functions

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/fa6755b1b677c6f45889f0b338e0ba4b19f748f9

[iannucci, 2016-01-12 18:25:49]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-01-12 18:25:50]

Wow, thanks for the additional test coverage! :)

Just some minor nits below

https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
File service/datastore/serialize/binary_tools_test.go (right):

https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
service/datastore/serialize/binary_tools_test.go:49: So(incr, ShouldResemble,
[]byte(nil))
So(incr, ShouldBeNil)

https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
service/datastore/serialize/binary_tools_test.go:50: So(overflow,
ShouldResemble, true)
So(overflow, ShouldBeTrue)

[nishanths (utexas), 2016-01-12 20:29:20]

On 2016/01/12 18:25:50, iannucci wrote:
> Wow, thanks for the additional test coverage! :)
> 
> Just some minor nits below
> 
>
https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
> File service/datastore/serialize/binary_tools_test.go (right):
> 
>
https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
> service/datastore/serialize/binary_tools_test.go:49: So(incr, ShouldResemble,
> []byte(nil))
> So(incr, ShouldBeNil)
> 
>
https://chromiumcodereview.appspot.com/1576353002/diff/1/service/datastore/se...
> service/datastore/serialize/binary_tools_test.go:50: So(overflow,
> ShouldResemble, true)
> So(overflow, ShouldBeTrue)

@iannucci: Done. :)

[iannucci, 2016-01-12 20:38:28]

https://chromiumcodereview.appspot.com/1576353002/diff/20001/service/datastor...
File service/datastore/serialize/binary_tools_test.go (right):

https://chromiumcodereview.appspot.com/1576353002/diff/20001/service/datastor...
service/datastore/serialize/binary_tools_test.go:55: So(incr, ShouldResemble,
[]byte(nil))
this ShouldBeNil too I think

[nishanths (utexas), 2016-01-12 20:42:09]

On 2016/01/12 20:38:28, iannucci wrote:
>
https://chromiumcodereview.appspot.com/1576353002/diff/20001/service/datastor...
> File service/datastore/serialize/binary_tools_test.go (right):
> 
>
https://chromiumcodereview.appspot.com/1576353002/diff/20001/service/datastor...
> service/datastore/serialize/binary_tools_test.go:55: So(incr, ShouldResemble,
> []byte(nil))
> this ShouldBeNil too I think

Apologies for missing that! Fixed now.

[iannucci, 2016-01-12 20:44:30]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-01-12 20:44:30]

lgtm

[commit-bot: I haz the power, 2016-01-12 20:44:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576353002/40001

[commit-bot: I haz the power, 2016-01-12 20:47:39]

Description was changed from

==========
Add tests for binary_tools functions

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=
==========

to

==========
Add tests for binary_tools functions

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=

Committed:
https://github.com/luci/gae/commit/fa6755b1b677c6f45889f0b338e0ba4b19f748f9
==========

[commit-bot: I haz the power, 2016-01-12 20:47:40]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/fa6755b1b677c6f45889f0b338e0ba4b19f748f9

[iannucci, 2016-01-12 20:49:25]

(thanks again!)