third_party/WebKit/Source/core/html/HTMLMediaElement.idl - Issue 1576283003: Have HTMLMediaElement::play() return a Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.idl

Issue 1576283003: Have HTMLMediaElement::play() return a Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.idl b/third_party/WebKit/Source/core/html/HTMLMediaElement.idl

index 9a133934d0abe68b0eda398f5d1ff529b968f730..21d84e5c31894674ce6245d63bad823b45ec3baf 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.idl

@@ -71,7 +71,7 @@ enum CanPlayTypeResult { "" /* empty string */, "maybe", "probably" };

readonly attribute boolean ended;

[Reflect] attribute boolean autoplay;

[Reflect] attribute boolean loop;

- void play();

+ [CallWith=ScriptState, ImplementedAs=playForBindings] Promise<void> play();

void pause();

// controls