third_party/WebKit/Source/core/testing/Internals.cpp - Issue 1576283003: Have HTMLMediaElement::play() return a Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 1576283003: Have HTMLMediaElement::play() return a Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/Internals.cpp

diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp

index b64438310952189c839cc91f4cd6784215ab5d59..6956f789b68e9347c3744550990fcaf41bd9a5f2 100644

--- a/third_party/WebKit/Source/core/testing/Internals.cpp

+++ b/third_party/WebKit/Source/core/testing/Internals.cpp

@@ -2548,8 +2548,8 @@ double Internals::monotonicTimeToZeroBasedDocumentTime(double platformTime, Exce

void Internals::setMediaElementNetworkState(HTMLMediaElement* mediaElement, int state)

{

ASSERT(mediaElement);

- ASSERT(state >= HTMLMediaElement::NetworkState::NETWORK_EMPTY);

- ASSERT(state <= HTMLMediaElement::NetworkState::NETWORK_NO_SOURCE);

+ ASSERT(state >= WebMediaPlayer::NetworkState::NetworkStateEmpty);

+ ASSERT(state <= WebMediaPlayer::NetworkState::NetworkStateDecodeError);

mediaElement->setNetworkState(static_cast<WebMediaPlayer::NetworkState>(state));

}