third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1576283003: Have HTMLMediaElement::play() return a Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1576283003: Have HTMLMediaElement::play() return a Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 0587c8118e1a33473fd23c174be70893b03b8b1b..9dac2786e90aa5a0eaf6392a51966088e87dace3 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3525,7 +3525,7 @@ void WebViewImpl::performMediaPlayerAction(const WebMediaPlayerAction& action,

switch (action.type) {

case WebMediaPlayerAction::Play:

if (action.enable)

- mediaElement->play();

+ mediaElement->playInternal();

philipj_slow 2016/02/02 09:56:34 Dito.

mlamouri (slow - plz ping) 2016/02/03 19:28:58 Fixed.

else

mediaElement->pause();

break;