third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 1576283003: Have HTMLMediaElement::play() return a Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 1576283003: Have HTMLMediaElement::play() return a Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index f8227ceb08b9f23789a9f777e3d47f94318a4d40..050db17881c8ab26da3e7c82d55a00c9e3633d45 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -315,7 +315,7 @@ PassRefPtrWillBeRawPtr<MediaControlOverlayPlayButtonElement> MediaControlOverlay

void MediaControlOverlayPlayButtonElement::defaultEventHandler(Event* event)

{

if (event->type() == EventTypeNames::click && mediaElement().paused()) {

- mediaElement().play();

+ mediaElement().playInternal();

philipj_slow 2016/02/02 09:56:33 Also potentially risky.

mlamouri (slow - plz ping) 2016/02/03 19:28:58 Reverted.

updateDisplayType();

event->setDefaultHandled();

}