Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 1576283002: mojo: Remove Pass() from MOJO_MOVE_ONLY_TYPE (Closed)

Created:
4 years, 11 months ago by danakj
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), dcheng, piman, qsr+mojo_chromium.org, Nico, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Remove Pass() from MOJO_MOVE_ONLY_TYPE The code that used this method has been replaced by std::move(), including in base's bind/callback, with the last few uses removed in this CL. So delete this now-obsolete method. R=yzshen@chromium.org,rockot@chromium.org BUG=557422, 561752 Committed: https://crrev.com/170623e9f2458902869fee96aba9bbea834f9a62 Cr-Commit-Position: refs/heads/master@{#369279}

Patch Set 1 #

Patch Set 2 : mojopass: mac/win #

Patch Set 3 : mojopass: morewindows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M device/serial/serial_device_enumerator_mac.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M device/serial/serial_device_enumerator_win.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/macros.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
danakj
4 years, 11 months ago (2016-01-12 01:38:30 UTC) #1
yzshen1
On 2016/01/12 01:38:30, danakj wrote: Please fix try bots.
4 years, 11 months ago (2016-01-12 06:59:36 UTC) #2
danakj
On 2016/01/12 06:59:36, yzshen1 wrote: > On 2016/01/12 01:38:30, danakj wrote: > > Please fix ...
4 years, 11 months ago (2016-01-12 19:55:32 UTC) #3
danakj
On 2016/01/12 19:55:32, danakj wrote: > On 2016/01/12 06:59:36, yzshen1 wrote: > > On 2016/01/12 ...
4 years, 11 months ago (2016-01-13 01:39:18 UTC) #4
yzshen1
lgtm
4 years, 11 months ago (2016-01-13 02:44:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576283002/40001
4 years, 11 months ago (2016-01-13 20:59:06 UTC) #7
danakj
+rocket for device/ (TBRing mechanical change)
4 years, 11 months ago (2016-01-13 21:20:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576283002/40001
4 years, 11 months ago (2016-01-13 21:23:26 UTC) #13
Ken Rockot(use gerrit already)
lgtm
4 years, 11 months ago (2016-01-13 22:23:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-13 23:09:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576283002/40001
4 years, 11 months ago (2016-01-13 23:14:24 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 01:16:51 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 01:18:13 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/170623e9f2458902869fee96aba9bbea834f9a62
Cr-Commit-Position: refs/heads/master@{#369279}

Powered by Google App Engine
This is Rietveld 408576698