[MD settings] OnStartup settings layout closer to mocks

[MD settings] OnStartup settings layout closer to mocks

This CL changes the layout of the OnStartup MD settings
to better match the mocks.  Some of the change involve
settings_dialog.css I haven't found the changes to have
an impact upon other uses of settings_dialog.css.

BUG=531750
Committed: https://crrev.com/365c1c8e4e45bb9fe9dc35696f1f030d044af2cc
Cr-Commit-Position: refs/heads/master@{#369027}

[dschuyler, 2016-01-11 23:57:17]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-01-12 00:13:09]

Did you also check the ChromeOS only "Powerwash" dialog?

[dpapad, 2016-01-12 00:43:47]

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_dialog.css (right):

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_dialog.css:56: flex: 1;
As discussed in person, it looks better to me to remove the flex:1 from here and
also remove the min-height from the "Add a page" dialog.

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared.css:65: margin-top: 8px;
Nit: You can use shortened syntax for the 4 margin values as follows.
margin: 8px 12px;

[dschuyler, 2016-01-12 19:49:38]

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_dialog.css (right):

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_dialog.css:56: flex: 1;
On 2016/01/12 00:43:47, dpapad wrote:
> As discussed in person, it looks better to me to remove the flex:1 from here
and
> also remove the min-height from the "Add a page" dialog.

I like those suggestions.  I've asked Alan for his thoughts.
I'm going to make these changes for now and make adjustments
later if Alan would like the layout done differently.

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1576253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared.css:65: margin-top: 8px;
On 2016/01/12 00:43:47, dpapad wrote:
> Nit: You can use shortened syntax for the 4 margin values as follows.
> margin: 8px 12px;

Done.

[dpapad, 2016-01-12 20:11:27]

lgtm

LGTM with question.

https://codereview.chromium.org/1576253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_dialog.css (right):

https://codereview.chromium.org/1576253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_dialog.css:32: flex-flow: column;
Nit: I don't think these make any visual difference, do they?

[dschuyler, 2016-01-12 20:27:02]

https://codereview.chromium.org/1576253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_dialog.css (right):

https://codereview.chromium.org/1576253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_dialog.css:32: flex-flow: column;
On 2016/01/12 20:11:27, dpapad wrote:
> Nit: I don't think these make any visual difference, do they?

Ah, I believe they did in Patch 1 of this CL and the
changes in Patch 2 made these changes obsolete.  Thanks.
I've removed these.

Done.

[dschuyler, 2016-01-12 23:01:05]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-01-12 23:01:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1576253002/#ps40001
(title: "review nit")

[commit-bot: I haz the power, 2016-01-12 23:03:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576253002/40001

[commit-bot: I haz the power, 2016-01-12 23:10:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 23:12:12]

Description was changed from

==========
[MD settings] OnStartup settings layout closer to mocks

This CL changes the layout of the OnStartup MD settings
to better match the mocks.  Some of the change involve
settings_dialog.css I haven't found the changes to have
an impact upon other uses of settings_dialog.css.

BUG=531750
==========

to

==========
[MD settings] OnStartup settings layout closer to mocks

This CL changes the layout of the OnStartup MD settings
to better match the mocks.  Some of the change involve
settings_dialog.css I haven't found the changes to have
an impact upon other uses of settings_dialog.css.

BUG=531750

Committed: https://crrev.com/365c1c8e4e45bb9fe9dc35696f1f030d044af2cc
Cr-Commit-Position: refs/heads/master@{#369027}
==========

[commit-bot: I haz the power, 2016-01-12 23:12:13]

Patchset 3 (id:??) landed as
https://crrev.com/365c1c8e4e45bb9fe9dc35696f1f030d044af2cc
Cr-Commit-Position: refs/heads/master@{#369027}