Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1576213002: Compute exportNamespace during resynthesizing. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute exportNamespace during resynthesizing. Also use it to find the entry point. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b9ff7c486048e8aa277af34a6667767e7786473b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -37 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +11 lines, -19 lines 1 comment Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 6 chunks +28 lines, -18 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-11 23:25:39 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1576213002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1576213002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode708 pkg/analyzer/lib/src/summary/resynthesize.dart:708: libraryElement.exportNamespace = Please add: // TODO(paulberry): compute the ...
4 years, 11 months ago (2016-01-11 23:33:41 UTC) #2
scheglov
4 years, 11 months ago (2016-01-12 00:37:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9ff7c486048e8aa277af34a6667767e7786473b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698