Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1576183002: SkTCopyOnFirstWrite-based SkPaintFilterCanvas API (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTCopyOnFirstWrite-based SkPaintFilterCanvas API I find this version preferable because 1) it consolidates the in/out paint args without compromising efficiency or flexibility 2) relieves overriders from having to set the SkTLazy explicitly BUG=skia:4782 R=mtklein@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1576183002 Committed: https://skia.googlesource.com/skia/+/32cdc32522bf39a8236880f57ff4ee5b26bdd363

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M include/core/SkTLazy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/utils/SkPaintFilterCanvas.h View 1 1 chunk +5 lines, -9 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
f(malita)
This is me discovering SkTCopyOnFirstWrite 1hr after landing the SkTLazy refactor.
4 years, 11 months ago (2016-01-11 22:44:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576183002/10007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576183002/10007
4 years, 11 months ago (2016-01-11 22:46:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 23:04:17 UTC) #8
reed1
lgtm
4 years, 11 months ago (2016-01-12 15:04:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576183002/10007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576183002/10007
4 years, 11 months ago (2016-01-12 15:20:33 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 15:21:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:10007) as
https://skia.googlesource.com/skia/+/32cdc32522bf39a8236880f57ff4ee5b26bdd363

Powered by Google App Engine
This is Rietveld 408576698