Chromium Code Reviews
DescriptionHandle setters properly in NameFilter.
According to the language spec (which we are trying to follow as closely
as possible in the implementation of summaries), a setter for `x` has a
name `x=`, hence a combinator like `show x` should show both the name
`x` and `x=`.
This has no immediate effect beyond the unit test for NameFilter (since
at the moment the only names which are affected by the behavior of
NameFilter are the names of classes, and they never end in `=`). But in
a future CL I plan to use NameFilter to help build public and export
namespaces, and once that lands I will need NameFilter to handle setters
properly.
R=scheglov@google.com
Committed: https://github.com/dart-lang/sdk/commit/927744e318709d002cffa3dc5a1aeb1d60397545
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
||||||||||||||||||||||||||||