Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1576173002: Handle setters properly in NameFilter. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle setters properly in NameFilter. According to the language spec (which we are trying to follow as closely as possible in the implementation of summaries), a setter for `x` has a name `x=`, hence a combinator like `show x` should show both the name `x` and `x=`. This has no immediate effect beyond the unit test for NameFilter (since at the moment the only names which are affected by the behavior of NameFilter are the names of classes, and they never end in `=`). But in a future CL I plan to use NameFilter to help build public and export namespaces, and once that lands I will need NameFilter to handle setters properly. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/927744e318709d002cffa3dc5a1aeb1d60397545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/prelink_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-11 22:05:56 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-11 22:22:04 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 927744e318709d002cffa3dc5a1aeb1d60397545 (presubmit successful).
4 years, 11 months ago (2016-01-11 22:28:48 UTC) #5
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-12 00:03:41 UTC) #6
Brian Wilkerson
4 years, 11 months ago (2016-01-12 00:03:42 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698