Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1576163002: Move scroll-snap related properties into CSSPropertyParser (Closed)

Created:
4 years, 11 months ago by rwlbuis
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move scroll-snap related properties into CSSPropertyParser Move scroll-snap-coordinate, scroll-snap-points-x and scroll-snap-points-y from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/2bc4a11520e612df3855fbfdf55c2035441f2b82 Cr-Commit-Position: refs/heads/master@{#368898}

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -83 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 chunks +2 lines, -75 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL. This removes some parsePosition related helpers from LegacyCSSPropertyParser.cpp...
4 years, 11 months ago (2016-01-11 22:48:17 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1576163002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1576163002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode2917 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2917: if (parsedValue && (parsedValue->isCalculated() || parsedValue->getDoubleValue() > 0)) ...
4 years, 11 months ago (2016-01-12 05:19:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576163002/40001
4 years, 11 months ago (2016-01-12 15:23:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 16:48:02 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 16:49:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2bc4a11520e612df3855fbfdf55c2035441f2b82
Cr-Commit-Position: refs/heads/master@{#368898}

Powered by Google App Engine
This is Rietveld 408576698