Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1576113005: Fix typo (Closed)

Created:
4 years, 11 months ago by wzhong
Modified:
4 years, 11 months ago
Reviewers:
slan, brettw, bcf
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo GN string needs double rather than single quote. BUG= Committed: https://crrev.com/f36b8e8274a5f07914c27a1abefb38f4c9a6ec24 Cr-Commit-Position: refs/heads/master@{#368961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/config/chromecast/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
wzhong
4 years, 11 months ago (2016-01-12 02:13:06 UTC) #2
slan
lgtm
4 years, 11 months ago (2016-01-12 02:15:47 UTC) #3
brettw
lgtm
4 years, 11 months ago (2016-01-12 19:09:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576113005/1
4 years, 11 months ago (2016-01-12 19:11:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 20:02:56 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 20:04:27 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f36b8e8274a5f07914c27a1abefb38f4c9a6ec24
Cr-Commit-Position: refs/heads/master@{#368961}

Powered by Google App Engine
This is Rietveld 408576698