Audio Player: Consider top padding of the app to calculate window size.

ui/file_manager/audio_player/js/audio_player.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Overrided metadata worker's path.
  * @type {string}
  */
 ContentMetadataProvider.WORKER_SCRIPT = '/js/metadata_worker.js';
 
@@ skipping 332 matching lines @@
   }
 };
 
 /* Keep the below constants in sync with the CSS. */
 
 /**
  * Window header size in pixels.
  * @type {number}
  * @const
  */
-AudioPlayer.HEADER_HEIGHT = 36;  // 32px + border 4px
+AudioPlayer.HEADER_HEIGHT = 33;  // 32px + border 1px
+
+/**
+ * Top padding height of audio player in pixels.
+ * @type {number}
+ * @const
+ */
+AudioPlayer.TOP_PADDING_HEIGHT = 4;
 
 /**
  * Track height in pixels.
  * @type {number}
  * @const
  */
 AudioPlayer.TRACK_HEIGHT = 48;
 
+

[yawano, 2016/01/13 10:24:02]

nit: unnecessary blank line.

[fukino, 2016/01/14 02:25:18]

Done.

 /**
  * Controls bar height in pixels.
  * @type {number}
  * @const
  */
 AudioPlayer.CONTROLS_HEIGHT = 96;
 
 /**
  * Default number of items in the expanded mode.
  * @type {number}
  * @const
  */
 AudioPlayer.DEFAULT_EXPANDED_ITEMS = 5;
 
 /**
  * Minimum size of the window in the expanded mode in pixels.
  * @type {number}
  * @const
  */
-AudioPlayer.EXPANDED_MODE_MIN_HEIGHT = AudioPlayer.CONTROLS_HEIGHT +
-                                       AudioPlayer.TRACK_HEIGHT * 2;
+AudioPlayer.EXPANDED_MODE_MIN_HEIGHT = AudioPlayer.TOP_PADDING_HEIGHT +
+                                       AudioPlayer.TRACK_HEIGHT * 2 +
+                                       AudioPlayer.CONTROLS_HEIGHT;
 
 /**
  * Invoked when the 'expanded' property in the model is changed.
  * @param {boolean} newValue New value.
  * @private
  */
 AudioPlayer.prototype.onExpandedChanged_ = function(newValue) {
   if (this.isExpanded_ !== null &&
       this.isExpanded_ === newValue)
     return;
 
   if (this.isExpanded_ && !newValue)
-    this.lastExpandedHeight_ = window.innerHeight;
+    this.lastExpandedInnerHeight_ = window.innerHeight;
 
   if (this.isExpanded_ !== newValue) {
     this.isExpanded_ = newValue;
     this.syncHeight_();
 
     // Saves new state.
     window.appState.expanded = newValue;
     util.saveAppState();
   }
 };
 
 /**
  * @private
  */
 AudioPlayer.prototype.syncHeight_ = function() {
-  var targetHeight;
+  var targetInnerHeight;
 
   if (this.player_.expanded) {
     // Expanded.
-    if (!this.lastExpandedHeight_ ||
-        this.lastExpandedHeight_ < AudioPlayer.EXPANDED_MODE_MIN_HEIGHT) {
+    if (!this.lastExpandedInnerHeight_ ||
+        this.lastExpandedInnerHeight_ < AudioPlayer.EXPANDED_MODE_MIN_HEIGHT) {
       var expandedListHeight =
           Math.min(this.entries_.length, AudioPlayer.DEFAULT_EXPANDED_ITEMS) *
               AudioPlayer.TRACK_HEIGHT;
-      targetHeight = AudioPlayer.CONTROLS_HEIGHT + expandedListHeight;
-      this.lastExpandedHeight_ = targetHeight;
+      targetInnerHeight = AudioPlayer.TOP_PADDING_HEIGHT +
+                          expandedListHeight +
+                          AudioPlayer.CONTROLS_HEIGHT;
+      this.lastExpandedInnerHeight_ = targetInnerHeight;
     } else {
-      targetHeight = this.lastExpandedHeight_;
+      targetInnerHeight = this.lastExpandedInnerHeight_;
     }
   } else {
     // Not expanded.
-    targetHeight = AudioPlayer.CONTROLS_HEIGHT + AudioPlayer.TRACK_HEIGHT;
+    targetInnerHeight = AudioPlayer.TOP_PADDING_HEIGHT +
+                        AudioPlayer.TRACK_HEIGHT +
+                        AudioPlayer.CONTROLS_HEIGHT;
   }
-
-  window.resizeTo(window.innerWidth, targetHeight + AudioPlayer.HEADER_HEIGHT);
+  window.resizeTo(window.outerWidth,

[fukino, 2016/01/13 08:20:21]

Not related to the issue, but it should be outerWidth rather than innerWidth,
since window.resizeTo specifies outer bounds.

+                  AudioPlayer.HEADER_HEIGHT + targetInnerHeight);
 };
 
 /**
  * Create a TrackInfo object encapsulating the information about one track.
  *
  * @param {FileEntry} entry FileEntry to be retrieved the track info from.
  * @constructor
  */
 AudioPlayer.TrackInfo = function(entry) {
   this.url = entry.toURL();
@@ skipping 37 matching lines @@
   // TODO(yoshiki): Handle error in better way.
   // TODO(yoshiki): implement artwork (metadata.thumbnail)
   this.title = metadata.mediaTitle || this.getDefaultTitle();
   this.artist = error || metadata.mediaArtist || this.getDefaultArtist();
 };
 
 // Starts loading the audio player.
 window.addEventListener('DOMContentLoaded', function(e) {
   AudioPlayer.load();
 });