Audio Player: Consider top padding of the app to calculate window size.

Audio Player: Consider top padding of the app to calculate window size.

The new audio player has 4px top padding, which is shown white under the window header.
The window size calculation didn't consider it, which causes issues.
- Playlist height grows (issue 576622)
- Scroll bar can be shown when it shouldn't be.
This CL fixes the calculation.

BUG=576622
TEST=manually

Committed: https://crrev.com/a395c224bd80d7d9c87094a7dbc7ebeafa6bb4ed
Cr-Commit-Position: refs/heads/master@{#369345}

[fukino, 2016-01-13 08:20:21]

fukino@chromium.org changed reviewers:
+ yawano@chromium.org

[fukino, 2016-01-13 08:20:21]

PTAL. Thanks!

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/audio_player.js:442:
window.resizeTo(window.outerWidth,
Not related to the issue, but it should be outerWidth rather than innerWidth,
since window.resizeTo specifies outer bounds.

[yawano, 2016-01-13 10:24:02]

lgtm with nit. Thank you!

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/audio_player.js:369: 
nit: unnecessary blank line.

[fukino, 2016-01-14 02:25:18]

Thank you!

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1576093006/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/audio_player.js:369: 
On 2016/01/13 10:24:02, yawano wrote:
> nit: unnecessary blank line.

Done.

[fukino, 2016-01-14 02:25:24]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-01-14 02:25:24]

The patchset sent to the CQ was uploaded after l-g-t-m from yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/1576093006/#ps20001
(title: "Remove a blank line.")

[commit-bot: I haz the power, 2016-01-14 02:28:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576093006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576093006/20001

[commit-bot: I haz the power, 2016-01-14 04:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 04:39:27]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)

[fukino, 2016-01-14 05:00:41]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-01-14 05:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576093006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576093006/20001

[commit-bot: I haz the power, 2016-01-14 06:06:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 06:08:01]

Description was changed from

==========
Audio Player: Consider top padding of the app to calculate window size.

The new audio player has 4px top padding, which is shown white under the window
header.
The window size calculation didn't consider it, which causes issues.
- Playlist height grows (issue 576622)
- Scroll bar can be shown when it shouldn't be.
This CL fixes the calculation.

BUG=576622
TEST=manually
==========

to

==========
Audio Player: Consider top padding of the app to calculate window size.

The new audio player has 4px top padding, which is shown white under the window
header.
The window size calculation didn't consider it, which causes issues.
- Playlist height grows (issue 576622)
- Scroll bar can be shown when it shouldn't be.
This CL fixes the calculation.

BUG=576622
TEST=manually

Committed: https://crrev.com/a395c224bd80d7d9c87094a7dbc7ebeafa6bb4ed
Cr-Commit-Position: refs/heads/master@{#369345}
==========

[commit-bot: I haz the power, 2016-01-14 06:08:01]

Patchset 2 (id:??) landed as
https://crrev.com/a395c224bd80d7d9c87094a7dbc7ebeafa6bb4ed
Cr-Commit-Position: refs/heads/master@{#369345}