cpsir unittests: move all unittests into individual files and test runners.

cpsir unittests: move all unittests into individual files and test runners.

Notes: most test code was copied from the original test files. The expectations
in patchset #1 are what we had in the files, expectations in patchset #2 are the
updated expectations.

Here is how the files under tests/compiler/dart2js/cps_ir/ are organized:
  - up_to_date_test.dart: test that checks that your files are up to date, and
    gives you the option to update them.
    - passing "update" as an argument will update all *_test.dart files in
      this folder and "update_all.dart".

  - some_name_N_test.dart: a unit test
    - takes cps_ir/input/some_name_N.dart as input, compiles it, and compares
      the output to cps_ir/expected/some_name_N.js
    - it accepts "update" as a command line argument to update the expectations in place

  - update_all.dart: updates expectations on all tests.

  - runner.dart: imported from all individual tests, basically an adaptation of
    the logic from js_backend_cps_ir.dart.

Test failures indicate how to update them, normally you will run 2 commands:
    up_to_date_test.dart update // to update the list of tests
    update_all.dart             // to update the expectations.

R=asgerf@google.com, kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/c3b7e13c4c14a33c06814ed92ca7436b084df0c8

[Siggi Cherem (dart-lang), 2016-01-12 04:32:10]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-01-12 04:40:04]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-01-12 04:40:26]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-01-12 05:00:29]

Patchset #1 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2016-01-12 05:00:46]

Patchset #1 (id:80001) has been deleted

[Siggi Cherem (dart-lang), 2016-01-12 05:05:18]

sigmund@google.com changed reviewers:
+ asgerf@google.com, kmillikin@google.com

[Siggi Cherem (dart-lang), 2016-01-12 05:05:19]

Let me know what you think.

There are a couple tests I still have to update (the failing tests might have
been tests that were checking for a specific function that now is being inlined)

[Siggi Cherem (dart-lang), 2016-01-12 17:21:46]

All tests are passing now. I uploaded a new version which includes the fixes and
a README.

I should have mentioned earlier that this CL looks huge, but you can skip most
of it.

 - skip all the individual some_test_N_test.dart (they are autogenerated)

 - skip all but 2 files under input/. These are copied from the TestEntrys we
had before, except 2 tests: operator_7 & supercall_2. These were commented out
saying that they need support for interceptor calls. I believe that is working
now, so I added them.

 - only look at the diff between patch-set 1 and 3 for the expectation files (to
see if anything surprising happened while we were suppressing the tests).
Patchset #1 has the original expectations (except maybe for
operator_7/supercall_2)

 - there is little to review on runner.dart: this was derived from
js_backend_cps_ir.dart

 - up_to_date_test.dart and README are new.

[Kevin Millikin (Google), 2016-01-12 17:45:48]

I have a wording suggestion, but it LGTM.  This will be nice to have.

https://codereview.chromium.org/1576093003/diff/160001/tests/compiler/dart2js...
File tests/compiler/dart2js/cps_ir/up_to_date_test.dart (right):

https://codereview.chromium.org/1576093003/diff/160001/tests/compiler/dart2js...
tests/compiler/dart2js/cps_ir/up_to_date_test.dart:50: print('PASS: ${filename}
is up to date.');
I think the focus of these messages should be on the fact that the test did or
did not match expectations (not on updating the expectation).  Suggest:

PASS: $filename matches the expectation

INFO: $filename was updated

FAILED: {$exists ? 'unexpected JavaScript code' : 'missing expectation'} for
$filename

[asgerf, 2016-01-12 17:56:10]

I love it! LGTM

[Siggi Cherem (dart-lang), 2016-01-12 17:58:26]

Thanks guys! I'll land shortly

[Siggi Cherem (dart-lang), 2016-01-12 18:00:53]

Description was changed from

==========
cpsir unittests: move all unittests into individual files and test runners.

Notes: most test code was copied from the original test files. The expectations
in patchset #1 are what we had in the files, expectations in patchset #2 are the
updated expectations.

Here is how the files under tests/compiler/dart2js/cps_ir/ are organized:
  - up_to_date_test.dart: test that checks that your files are up to date, and
    gives you the option to update them.
    - passing "update" as an argument will update all *_test.dart files in
      this folder and "update_all.dart".

  - some_name_N_test.dart: a unit test
    - takes cps_ir/input/some_name_N.dart as input, compiles it, and compares
      the output to cps_ir/expected/some_name_N.js
    - it accepts "update" as a command line argument to update the expectations
in place

  - update_all.dart: updates expectations on all tests.

  - runner.dart: imported from all individual tests, basically an adaptation of
    the logic from js_backend_cps_ir.dart.

Test failures indicate how to update them, normally you will run 2 commands:
    up_to_date_test.dart update // to update the list of tests
    update_all.dart             // to update the expectations.
==========

to

==========
cpsir unittests: move all unittests into individual files and test runners.

Notes: most test code was copied from the original test files. The expectations
in patchset #1 are what we had in the files, expectations in patchset #2 are the
updated expectations.

Here is how the files under tests/compiler/dart2js/cps_ir/ are organized:
  - up_to_date_test.dart: test that checks that your files are up to date, and
    gives you the option to update them.
    - passing "update" as an argument will update all *_test.dart files in
      this folder and "update_all.dart".

  - some_name_N_test.dart: a unit test
    - takes cps_ir/input/some_name_N.dart as input, compiles it, and compares
      the output to cps_ir/expected/some_name_N.js
    - it accepts "update" as a command line argument to update the expectations
in place

  - update_all.dart: updates expectations on all tests.

  - runner.dart: imported from all individual tests, basically an adaptation of
    the logic from js_backend_cps_ir.dart.

Test failures indicate how to update them, normally you will run 2 commands:
    up_to_date_test.dart update // to update the list of tests
    update_all.dart             // to update the expectations.

R=asgerf@google.com, kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c3b7e13c4c14a33c06814ed92ca7436b084df0c8
==========

[Siggi Cherem (dart-lang), 2016-01-12 18:00:55]

Committed patchset #5 (id:180001) manually as
c3b7e13c4c14a33c06814ed92ca7436b084df0c8 (presubmit successful).