Issue 1576073002: [Merge] Custom buttons should only handle accelerators when focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1576073002: [Merge] Custom buttons should only handle accelerators when focused. (Closed)

Created:
4 years, 11 months ago by felt

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

[Merge] Custom buttons should only handle accelerators when focused. BUG=541415 Review URL: https://codereview.chromium.org/1437523005 Cr-Commit-Position: refs/heads/master@{#360130} (cherry picked from commit 297ae873b471a46929ea39697b121c0b411434ee) Committed: https://chromium.googlesource.com/chromium/src/+/1f9ac4cc322f57588be9b138f9b4d8df4e7cf288

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -3 lines)			Patch
M	ui/views/controls/button/custom_button.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/views/controls/button/custom_button.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	ui/views/controls/button/custom_button_unittest.cc	View	4 chunks	+54 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

felt

4 years, 11 months ago (2016-01-11 18:01:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1f9ac4cc322f57588be9b138f9b4d8df4e7cf288.