Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1576053002: Move core2md objects to libbreakpad_client.a (Closed)

Created:
4 years, 11 months ago by domlaskowski
Modified:
4 years, 11 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move core2md objects to libbreakpad_client.a This CL exports LinuxCoreDumper and ElfCoreDump in the client library. The ARC collector, which is an alternative to core2md optimized for large core dumps, needs these symbols for core dump parsing and conversion to minidump. BUG=http://b/25773929 TEST=nm src/client/linux/libbreakpad_client.a | grep LinuxCoreDumper Committed: https://chromium.googlesource.com/breakpad/breakpad/+/e8dc9aab0cf8e0a887ecf271c6ffa9f3d573edf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M Makefile.am View 3 chunks +3 lines, -3 lines 0 comments Download
M Makefile.in View 11 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
domlaskowski
4 years, 11 months ago (2016-01-11 17:39:42 UTC) #3
vapier
can you provide a reason/BUG in the commit description ?
4 years, 11 months ago (2016-01-12 07:38:27 UTC) #4
domlaskowski
Updated description.
4 years, 11 months ago (2016-01-12 18:58:03 UTC) #6
vapier
Committed patchset #1 (id:1) manually as e8dc9aab0cf8e0a887ecf271c6ffa9f3d573edf2 (presubmit successful).
4 years, 11 months ago (2016-01-13 20:30:26 UTC) #8
vapier
4 years, 11 months ago (2016-01-13 20:30:40 UTC) #9
Message was sent while issue was closed.
lgtm ;)

Powered by Google App Engine
This is Rietveld 408576698