Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1576033002: Merge to XFA: Use std::map as CPDF_Dictionary's underlying store. (Closed)

Created:
4 years, 11 months ago by Oliver Chang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Use std::map as CPDF_Dictionary's underlying store. Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr so it's not completely removed just yet. Adds begin()/end() to CPDF_Dictionary and removes the GetStartPos()/GetNextElement() functions to traverse the dictionary. Callers are changed accordingly. AddValue() is also removed. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1541703003 . (cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f) Committed: https://pdfium.googlesource.com/pdfium/+/3f1c71f5a6ea058e3eec611c9dcc759b374dcb80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -268 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 4 chunks +13 lines, -7 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +0 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 5 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 8 chunks +56 lines, -82 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 4 chunks +9 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 3 chunks +8 lines, -13 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 6 chunks +17 lines, -30 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfedit_embeddertest.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +17 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Oliver Chang
TBR. clean merge apart from a trivial change in xfa_fontmgr.cpp
4 years, 11 months ago (2016-01-11 16:42:54 UTC) #1
Oliver Chang
4 years, 11 months ago (2016-01-11 16:45:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f1c71f5a6ea058e3eec611c9dcc759b374dcb80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698