Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1575973006: [builtins] Sanitize receiver patching for API functions. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Sanitize receiver patching for API functions. The API functions are always in sloppy mode, so receiver is always a JSReceiver once the actual call trampoline runs, no need to check again in various places. R=verwaest@chromium.org Committed: https://crrev.com/12bcba1543235c3e0fc02b11aecf7fc16fdf06a8 Cr-Commit-Position: refs/heads/master@{#33258}

Patch Set 1 #

Patch Set 2 : Fix dead code #

Patch Set 3 : Moar fixes #

Patch Set 4 : Fix #

Patch Set 5 : REBASE. MIPS fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -115 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 chunks +1 line, -18 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 chunks +1 line, -18 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 3 chunks +1 line, -20 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 3 chunks +3 lines, -19 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 3 chunks +3 lines, -19 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +1 line, -17 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-12 16:08:34 UTC) #1
Benedikt Meurer
Hey Toon, Removing some dead code. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-12 16:12:04 UTC) #2
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-12 16:21:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973006/40001
4 years, 11 months ago (2016-01-12 16:22:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/8784)
4 years, 11 months ago (2016-01-12 17:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973006/60001
4 years, 11 months ago (2016-01-12 17:09:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13873)
4 years, 11 months ago (2016-01-12 17:56:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973006/80001
4 years, 11 months ago (2016-01-13 05:22:11 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-13 05:57:56 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 05:59:00 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/12bcba1543235c3e0fc02b11aecf7fc16fdf06a8
Cr-Commit-Position: refs/heads/master@{#33258}

Powered by Google App Engine
This is Rietveld 408576698