Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1575973003:
Switch our version of jsoncpp to match the one used in Chromium. (Closed)
DescriptionUpdate our version of jsoncpp to fix a memory alignment bug in the library.
This upgrades the library to 1.0.0 instead of the most recent release, since more recent releases require exceptions to be enabled.
BUG=skia:4775
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1575973003
Committed: https://skia.googlesource.com/skia/+/950e626fb43004c010aa4d9d5ff5247e0d5f94fa
Patch Set 1 #Patch Set 2 : upgrade #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Switch our version of jsoncpp to match the one used in Chromium. BUG=skia:4775 ========== to ========== Switch our version of jsoncpp to match the one used in Chromium. BUG=skia:4775 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by djsollen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973003/1
djsollen@google.com changed reviewers: + scroggo@google.com
Description was changed from ========== Switch our version of jsoncpp to match the one used in Chromium. BUG=skia:4775 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch our version of jsoncpp to match the one used in Chromium. See https://chromium.googlesource.com/chromium/src/+/e738b541eb7800ae018da462f718... for the corresponding DEPS entry in chromium. BUG=skia:4775 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
Description was changed from ========== Switch our version of jsoncpp to match the one used in Chromium. See https://chromium.googlesource.com/chromium/src/+/e738b541eb7800ae018da462f718... for the corresponding DEPS entry in chromium. BUG=skia:4775 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update our version of jsoncpp to fix a memory alignment bug in the library. This upgrades the library to 1.0.0 instead of the most recent release, since more recent releases require exceptions to be enabled. BUG=skia:4775 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by djsollen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by djsollen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575973003/20001
Message was sent while issue was closed.
Description was changed from
==========
Update our version of jsoncpp to fix a memory alignment bug in the library.
This upgrades the library to 1.0.0 instead of the most recent release, since
more recent releases require exceptions to be enabled.
BUG=skia:4775
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========
to
==========
Update our version of jsoncpp to fix a memory alignment bug in the library.
This upgrades the library to 1.0.0 instead of the most recent release, since
more recent releases require exceptions to be enabled.
BUG=skia:4775
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
Committed:
https://skia.googlesource.com/skia/+/950e626fb43004c010aa4d9d5ff5247e0d5f94fa
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/950e626fb43004c010aa4d9d5ff5247e0d5f94fa |
