Source position tests for switch and try catch finally

Source position tests for switch and try catch finally

- Give AwaitMarkerNode a token position.
- Make it possible to provide a token position for SaveContext, RestoreContext, StoreContext, and CurrentContext.
- Pass in a token position to internally generated StoreLocal and LoadLocal instructions for try-catch-finally.
- Introduce a Context ClassifyingTokenPosition to be used when we can't attribute a context related instruction to a source position.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/bda2b3d2ff3b6622e7d304b40a2bdb2ff4fab640

[Cutch, 2016-01-12 22:15:40]

Description was changed from

==========
Source position tests for switch and try catch finally

BUG=
==========

to

==========
Source position tests for switch and try catch finally

- Give AwaitMarkerNode a token position.
- Make it possible to provide a token position for SaveContext, RestoreContext,
StoreContext, and CurrentContext.
- Pass in a token position to internally generated StoreLocal and LoadLocal
instructions for try-catch-finally.
- Introduce a Context ClassifyingTokenPosition to be used when we can't
attribute a context related instruction to a source position.
==========

[Cutch, 2016-01-12 22:15:40]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-01-12 22:59:21]

lgtm

https://codereview.chromium.org/1575953005/diff/1/runtime/vm/flow_graph_build...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1575953005/diff/1/runtime/vm/flow_graph_build...
runtime/vm/flow_graph_builder_test.cc:601: spt.InstanceCallAt(6, 10,
Token::kEQ);                         // '1'
'1' => '2'

[Cutch, 2016-01-12 23:02:15]

https://codereview.chromium.org/1575953005/diff/1/runtime/vm/flow_graph_build...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1575953005/diff/1/runtime/vm/flow_graph_build...
runtime/vm/flow_graph_builder_test.cc:601: spt.InstanceCallAt(6, 10,
Token::kEQ);                         // '1'
On 2016/01/12 22:59:21, rmacnak wrote:
> '1' => '2'

Done.

[Cutch, 2016-01-12 23:02:38]

Description was changed from

==========
Source position tests for switch and try catch finally

- Give AwaitMarkerNode a token position.
- Make it possible to provide a token position for SaveContext, RestoreContext,
StoreContext, and CurrentContext.
- Pass in a token position to internally generated StoreLocal and LoadLocal
instructions for try-catch-finally.
- Introduce a Context ClassifyingTokenPosition to be used when we can't
attribute a context related instruction to a source position.
==========

to

==========
Source position tests for switch and try catch finally

- Give AwaitMarkerNode a token position.
- Make it possible to provide a token position for SaveContext, RestoreContext,
StoreContext, and CurrentContext.
- Pass in a token position to internally generated StoreLocal and LoadLocal
instructions for try-catch-finally.
- Introduce a Context ClassifyingTokenPosition to be used when we can't
attribute a context related instruction to a source position.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bda2b3d2ff3b6622e7d304b40a2bdb2ff4fab640
==========

[Cutch, 2016-01-12 23:02:40]

Committed patchset #1 (id:1) manually as
bda2b3d2ff3b6622e7d304b40a2bdb2ff4fab640 (presubmit successful).