PolymerTestBase: Load mock-interactions.js instead of importing HTML

PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1] https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0447e59d30b9985110c4574f

BUG=576828
Committed: https://crrev.com/2d90ebf4ec6783ce4da185f2364fa190d084c1c1
Cr-Commit-Position: refs/heads/master@{#368994}

[michaelpg, 2016-01-12 19:14:34]

Description was changed from

==========
Load mock-interactions.js instead of importing HTML

BUG=
==========

to

==========
PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1]
https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0...

BUG=576828
==========

[michaelpg, 2016-01-12 19:14:34]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org, imcheng@chromium.org

[michaelpg, 2016-01-12 19:14:34]

michaelpg@chromium.org changed required reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-01-12 19:18:31]

PTAL, this unblocks https://codereview.chromium.org/1561893002/

After speaking with cdata@ this sounds like our best option.

[imcheng, 2016-01-12 19:24:43]

lgtm, thanks for investigating!

[Dan Beam, 2016-01-12 20:12:59]

this code seems fine, by why isn't the import of polymer.html de-duped?  because
of the way we're dynamically importing?

https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/polymer_browser_test_base.js:151: * @return {Promise} A
promise that is resolved/rejected on success/failure.
nit: !Promise

[michaelpg, 2016-01-12 20:14:48]

On 2016/01/12 20:12:59, Dan Beam wrote:
> this code seems fine, by why isn't the import of polymer.html de-duped? 
because
> of the way we're dynamically importing?

no, it's because the Downloads UI isn't importing polymer.html... when it's
vulcanized.

Any attempt to import other Polymer or MD-Downloads HTML files in a test when
using
the vulcanized build will likely lead to the same sort of problem.

> 
>
https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
> File chrome/test/data/webui/polymer_browser_test_base.js (right):
> 
>
https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
> chrome/test/data/webui/polymer_browser_test_base.js:151: * @return {Promise} A
> promise that is resolved/rejected on success/failure.
> nit: !Promise

[michaelpg, 2016-01-12 20:16:16]

https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1575953004/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/polymer_browser_test_base.js:151: * @return {Promise} A
promise that is resolved/rejected on success/failure.
On 2016/01/12 20:12:59, Dan Beam wrote:
> nit: !Promise

Done.

[Dan Beam, 2016-01-12 20:17:06]

ah, lgtm

who added that damn vulcanized version anyway?!

[michaelpg, 2016-01-12 20:19:24]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-01-12 20:19:24]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1575953004/#ps60001
(title: "closure type")

[commit-bot: I haz the power, 2016-01-12 20:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575953004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575953004/60001

[commit-bot: I haz the power, 2016-01-12 21:40:43]

Description was changed from

==========
PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1]
https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0...

BUG=576828
==========

to

==========
PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1]
https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0...

BUG=576828
==========

[commit-bot: I haz the power, 2016-01-12 21:40:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-12 21:41:48]

Description was changed from

==========
PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1]
https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0...

BUG=576828
==========

to

==========
PolymerTestBase: Load mock-interactions.js instead of importing HTML

iron-test-helpers was updated upstream to import Polymer.[1] This
assumes Polymer is not already imported, an assumption that is
violated when we test a vulcanized source like Downloads.

By loading the script instead of the HTML we avoid re-importing
Polymer. This may stop working if mock-interactions.js becomes
dependent on other files.

[1]
https://github.com/PolymerElements/iron-test-helpers/commit/c9e045f520bed82a0...

BUG=576828

Committed: https://crrev.com/2d90ebf4ec6783ce4da185f2364fa190d084c1c1
Cr-Commit-Position: refs/heads/master@{#368994}
==========

[commit-bot: I haz the power, 2016-01-12 21:41:49]

Patchset 4 (id:??) landed as
https://crrev.com/2d90ebf4ec6783ce4da185f2364fa190d084c1c1
Cr-Commit-Position: refs/heads/master@{#368994}