Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1575943002: ozone: gracefully handle SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior (Closed)

Created:
4 years, 11 months ago by dshwang
Modified:
4 years, 11 months ago
Reviewers:
spang, ccameron
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: gracefully handle SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior The test crashes on ozone GBM, because GBM doesn't support software rendering mode. This CL makes the test gracefully done, instead of crash. [ RUN ] SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior [9442:9442:0111/131957:8760142320:FATAL:gbm_surface_factory.cc(88)] Software rendering mode is not supported with GBM platform TEST=content_unittests --gtest_filter=SoftwareOutputDeviceOzoneTest* --ozone-platform=gbm --ozone-use-surfaceless --single-process-tests Committed: https://crrev.com/296cfc9a8352fdd265d4e550fcff6efb616a7f0a Cr-Commit-Position: refs/heads/master@{#369372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/compositor/software_output_device_ozone.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dshwang
spang, could you review to fix crash of ozone content_unittests? ccameron, could you review content/? ...
4 years, 11 months ago (2016-01-11 14:22:06 UTC) #2
ccameron
On 2016/01/11 at 14:22:06, dongseong.hwang wrote: > spang, could you review to fix crash of ...
4 years, 11 months ago (2016-01-12 12:39:29 UTC) #4
spang
ui/ozone/ lgtm
4 years, 11 months ago (2016-01-13 19:41:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575943002/1
4 years, 11 months ago (2016-01-14 07:42:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 08:44:16 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 08:45:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/296cfc9a8352fdd265d4e550fcff6efb616a7f0a
Cr-Commit-Position: refs/heads/master@{#369372}

Powered by Google App Engine
This is Rietveld 408576698