Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 15759009: ui/aura: Use base::string16 now that string16 was moved into base namespace. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ui/aura: Use base::string16 now that string16 was moved into base namespace. base/string16.h was moved into base namespace in r191198 by Brett. BUG=None TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203079

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -76 lines) Patch
M ui/aura/client/cursor_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/tooltip_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/client/tooltip_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/remote_root_window_host_win.h View 1 2 chunks +31 lines, -36 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 8 chunks +25 lines, -28 lines 0 comments Download
M ui/aura/window.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
7 years, 6 months ago (2013-05-29 23:54:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15759009/1
7 years, 6 months ago (2013-05-29 23:55:28 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119810
7 years, 6 months ago (2013-05-30 01:09:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15759009/9003
7 years, 6 months ago (2013-05-30 03:28:19 UTC) #4
tfarina
Committed patchset #2 manually as r203079 (presubmit successful).
7 years, 6 months ago (2013-05-30 05:03:29 UTC) #5
Ben Goodger (Google)
7 years, 6 months ago (2013-05-30 16:12:30 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698