src/IceTargetLoweringX8632Traits.h - Issue 1575873006: Subzero: Fix g++ warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632Traits.h

Issue 1575873006: Subzero: Fix g++ warnings. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringX8632Traits.h

diff --git a/src/IceTargetLoweringX8632Traits.h b/src/IceTargetLoweringX8632Traits.h

index 00ea2d91cce1de6df2b2c935b27d5e3c9af07b77..c9121601ad6340e6187306a3e63c2df227bfbd54 100644

--- a/src/IceTargetLoweringX8632Traits.h

+++ b/src/IceTargetLoweringX8632Traits.h

@@ -116,7 +116,10 @@ struct TargetX8632Traits {

int32_t disp32() const {

assert(length_ >= 5);

- return bit_copy<int32_t>(encoding_[length_ - 4]);

+ // TODO(stichnot): This method is not currently used. Delete it along

+ // with other unused methods, or use a safe version of bitCopy().

+ llvm::report_fatal_error("Unexpected call to disp32()");

+ // return Utils::bitCopy<int32_t>(encoding_[length_ - 4]);

}

AssemblerFixup *fixup() const { return fixup_; }