Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1575843002: Add note about using the system linker with icecc (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
Nico, Bons
CC:
chromium-reviews, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note about using the system linker with icecc Committed: https://crrev.com/f6847d5442430a35270e6c0583bc1da85d1471bd Cr-Commit-Position: refs/heads/master@{#369177}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M docs/linux_faster_builds.md View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (3 generated)
davve
Since a recent Debian upgrade (testing) this seems to be required to be able to ...
4 years, 11 months ago (2016-01-11 10:04:40 UTC) #2
davve
ping.
4 years, 11 months ago (2016-01-13 09:46:12 UTC) #3
Bons
lgtm
4 years, 11 months ago (2016-01-13 13:38:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575843002/1
4 years, 11 months ago (2016-01-13 15:04:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 15:35:51 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6847d5442430a35270e6c0583bc1da85d1471bd Cr-Commit-Position: refs/heads/master@{#369177}
4 years, 11 months ago (2016-01-13 15:36:41 UTC) #9
Nico
https://codereview.chromium.org/1575843002/diff/1/docs/linux_faster_builds.md File docs/linux_faster_builds.md (right): https://codereview.chromium.org/1575843002/diff/1/docs/linux_faster_builds.md#newcode49 docs/linux_faster_builds.md:49: Using the system linker is necessary since a recent ...
4 years, 11 months ago (2016-01-13 20:47:16 UTC) #10
davve
4 years, 11 months ago (2016-01-14 08:13:03 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1575843002/diff/1/docs/linux_faster_builds.md
File docs/linux_faster_builds.md (right):

https://codereview.chromium.org/1575843002/diff/1/docs/linux_faster_builds.md...
docs/linux_faster_builds.md:49: Using the system linker is necessary since a
recent binutils upgrade.
On 2016/01/13 20:47:16, Nico wrote:
> What's "recent"? What will this mean in 4 months? Is there an upstream bug for
> this somewhere?

I get your point. :)

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808181

is an upstream bug I've found. From that it looks like it may have been not the
binutils but the libc upgrade to 2.21-4 that broke this.

New, more specific CL coming up. Thanks for your prodding!

Powered by Google App Engine
This is Rietveld 408576698