Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: test/mac/gyptest-archs.py

Issue 157583011: Fix generation for ninja of multiarch executable targets (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mac/gyptest-archs.py
diff --git a/test/mac/gyptest-archs.py b/test/mac/gyptest-archs.py
index 53810e40cc5becf2a8b21bb4fd770acb682c147c..0ae0697fa567b2af222cbb8c9346cff278140d17 100644
--- a/test/mac/gyptest-archs.py
+++ b/test/mac/gyptest-archs.py
@@ -53,8 +53,16 @@ if sys.platform == 'darwin':
CheckFileType(result_file, '^Mach-O 64-bit executable x86_64$')
if test.format != 'make':
+ # Build all targets except 'exe_32_64_no_sources' that does build
+ # but should not cause error when generating ninja files
+ targets = [
+ 'static_32_64', 'shared_32_64', 'module_32_64', 'exe_32_64',
+ 'exe_32_64_bundle', 'precompiled_prefix_header_mm_32_64',
+ ]
+
test.run_gyp('test-archs-multiarch.gyp', chdir='archs')
- test.build('test-archs-multiarch.gyp', test.ALL, chdir='archs')
+ for target in targets:
+ test.build('test-archs-multiarch.gyp', target=target, chdir='archs')
result_file = test.built_file_path(
'static_32_64', chdir='archs', type=test.STATIC_LIB)
« test/mac/archs/test-archs-multiarch.gyp ('K') | « test/mac/archs/test-archs-multiarch.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698