Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: pkg/polymer/lib/builder.dart

Issue 157583007: Removing polymer-specific code from barback runner (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer/lib/deploy.dart » ('j') | pkg/polymer/lib/deploy.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/builder.dart
diff --git a/pkg/polymer/lib/builder.dart b/pkg/polymer/lib/builder.dart
index 26813e71d314e8b175b0c505d45794344a48f9f3..9266894abfc49271e06d0090c6253cba76122471 100644
--- a/pkg/polymer/lib/builder.dart
+++ b/pkg/polymer/lib/builder.dart
@@ -191,10 +191,11 @@ Future deploy({List<String> entryPoints, CommandLineOptions options,
contentSecurityPolicy: options.contentSecurityPolicy,
releaseMode: options.releaseMode);
+ var phases = new PolymerTransformerGroup(transformOptions).phases;
var barbackOptions = new BarbackOptions(
- new PolymerTransformerGroup(transformOptions).phases,
- options.outDir, currentPackage: currentPackage,
- packageDirs: packageDirs, machineFormat: options.machineFormat);
+ phases, options.outDir, currentPackage: currentPackage,
+ packageDirs: packageDirs, machineFormat: options.machineFormat,
+ packagePhases: {'polymer' : phases});
Siggi Cherem (dart-lang) 2014/02/11 23:15:20 actually, for polymer we only need to apply the ob
blois 2014/02/12 02:39:27 Updated builder & deploy to cover this.
Siggi Cherem (dart-lang) 2014/02/12 03:05:28 awesome, thanks!
return runBarback(barbackOptions)
.then((_) => print('Done! All files written to "${options.outDir}"'));
}
« no previous file with comments | « no previous file | pkg/polymer/lib/deploy.dart » ('j') | pkg/polymer/lib/deploy.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698