Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1575743003: Mac: Remove a case where panels may become key when an autofill popup closes (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Remove a case where panels may become key when an autofill popup closes Since panels have a promoted -[NSWindow level], OSX prefers them to browser windows when it needs to activate a window. One case this happens is whenever an autofill popup is dismissed (e.g. when tabbing between text fields on a web page). Sometimes, a panel window may be activated in this case since it thinks it was the "previous" key window, when actually it was a browser window. The "previous" key window case doesn't really seem to add much. So remove it. It means that a panel can lose focus (and not immediately regain it) when another panel window is closed, but that seems preferable to tabbing into a Hangouts chat window instead of a password field when a username autofill popup is dismissed. (Note it doesn't happen if a *browser* window is closed, since the native close button doesn't activate a window, but the non-native hangouts close button does). The "allow previous" logic was included in r127517 (to fix http://crbug.com/112038). Closing hangouts windows seems to be the only use case it supports, and I don't think that use case will be missed. BUG=546509, 112038 Committed: https://crrev.com/5b81d65c7382b3b855cbc5bd26a15cc68ef4c5e5 Cr-Commit-Position: refs/heads/master@{#369347}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove poopie code from chrome_browser_application_mac.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -67 lines) Patch
M chrome/browser/chrome_browser_application_mac.h View 1 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 1 2 chunks +1 line, -51 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (14 generated)
tapted
Hi Scott, could you please take a look? Maybe you can think of a use-case ...
4 years, 11 months ago (2016-01-11 00:28:13 UTC) #6
tapted
shess: ping?
4 years, 11 months ago (2016-01-12 22:04:00 UTC) #7
Scott Hess - ex-Googler
https://codereview.chromium.org/1575743003/diff/1/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm File chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm (left): https://codereview.chromium.org/1575743003/diff/1/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm#oldcode98 chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm:98: [app previousKeyWindow] == self || AFAICT, the only reason ...
4 years, 11 months ago (2016-01-12 22:29:55 UTC) #8
tapted
On 2016/01/12 22:29:55, Scott Hess wrote: > https://codereview.chromium.org/1575743003/diff/1/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm > File chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm (left): > > https://codereview.chromium.org/1575743003/diff/1/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm#oldcode98 ...
4 years, 11 months ago (2016-01-13 02:40:49 UTC) #10
Scott Hess - ex-Googler
LGTM (Looks Grand To Me, because "good" isn't quite right). Keep an eye out for ...
4 years, 11 months ago (2016-01-13 23:57:44 UTC) #11
tapted
+mark for OWNERS in chrome_browser_application_mac.*
4 years, 11 months ago (2016-01-14 00:12:29 UTC) #13
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-14 00:25:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575743003/40001
4 years, 11 months ago (2016-01-14 00:42:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 01:47:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575743003/40001
4 years, 11 months ago (2016-01-14 02:54:03 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on ...
4 years, 11 months ago (2016-01-14 04:58:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575743003/40001
4 years, 11 months ago (2016-01-14 06:20:13 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-14 06:24:36 UTC) #26
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 06:25:33 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b81d65c7382b3b855cbc5bd26a15cc68ef4c5e5
Cr-Commit-Position: refs/heads/master@{#369347}

Powered by Google App Engine
This is Rietveld 408576698