Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1575743002: Add missing dependency from Blink IDLs to generated code aggregation (Closed)

Created:
4 years, 11 months ago by tzik
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency from Blink IDLs to generated code aggregation AudioContext is enabled only when WEB_AUDIO flag is on, which is described in AudioContext.idl. Implies that V8GeneratedModulesBindings05.cpp includes generated V8AudioContext.cpp only when the flag is on. So, V8GeneratedModulesBindings05.cpp has to depends on the content of the IDL, rather than the list of the IDL files. BUG=417628 Committed: https://crrev.com/42ab10ea1618d8a09c0d70d44153cc75ba83e181 Cr-Commit-Position: refs/heads/master@{#368534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/generated.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575743002/1
4 years, 11 months ago (2016-01-10 08:52:05 UTC) #3
tzik
PTAL
4 years, 11 months ago (2016-01-10 08:53:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-10 10:15:17 UTC) #7
haraken
LGTM Thanks for looking into this... I'll send the WEB_AUDIO CL to try bots once ...
4 years, 11 months ago (2016-01-10 12:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575743002/1
4 years, 11 months ago (2016-01-10 17:05:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-10 17:08:45 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-10 17:09:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42ab10ea1618d8a09c0d70d44153cc75ba83e181
Cr-Commit-Position: refs/heads/master@{#368534}

Powered by Google App Engine
This is Rietveld 408576698