Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 15757007: Revert 202364 "Track NPObject ownership by the originating plugi..." (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202364 "Track NPObject ownership by the originating plugi..." Suspected to have broken ClickToPlayPluginTest.NoCallbackAtLoad > Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) > > This CL updates Chrome to return plugin NPP identifiers for NPAPI, PPAPI and browser plugins, and to make the necessary calls into Blink to support object ownership tracking. > > This CL requires Blink CL crrev.com/14989014, and is itself required by Blink CL crrev.com/14019005. > > BUG=152006 > > Review URL: https://chromiumcodereview.appspot.com/15007012 TBR=wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -126 lines) Patch
M trunk/src/chrome/renderer/plugins/webview_plugin.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/renderer/plugins/webview_plugin.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/webplugin_delegate_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/webplugin_delegate_proxy.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/webkit/glue/cpp_bound_class.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/webkit/glue/cpp_bound_class.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M trunk/src/webkit/plugins/npapi/webplugin_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/webkit/plugins/npapi/webplugin_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/webkit/plugins/npapi/webplugin_impl.cc View 5 chunks +7 lines, -32 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/message_channel.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/plugin_object.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/ppapi_plugin_instance.h View 3 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/ppapi_plugin_instance.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/ppapi_webplugin_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
7 years, 7 months ago (2013-05-27 05:45:38 UTC) #1
kinuko
Committed patchset #1 manually as r202369.
7 years, 7 months ago (2013-05-27 05:46:26 UTC) #2
kinuko
7 years, 7 months ago (2013-05-27 05:49:06 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698