[Mac][MC] Allow popup notifications to be dismissed with a swipe gesture.

[Mac][MC] Allow popup notifications to be dismissed with a swipe gesture.

This UI exists in the 10.8 Notification Center and is nice to have.

BUG=238252
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201888

[Robert Sesek, 2013-05-22 23:54:29]

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:20: enum {
This is copied verbatim from RenderWidgetHostViewDelegateMac (or something).
Should we centralize it in base/ like we did with protocols?

[Nico, 2013-05-23 01:02:56]

nicenicenice

lgtm if the answer below is "just works".

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:20: enum {
On 2013/05/22 23:54:29, rsesek wrote:
> This is copied verbatim from RenderWidgetHostViewDelegateMac (or something).
> Should we centralize it in base/ like we did with protocols?

Probably a good idea. Can be in a follow-up if you want.

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:178:
messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
If the user cancels a swipe, does appkit animate back to amount of 0
automatically? i.e. do you need to reset the frame to originalFrame_ or does
that just work?

[Robert Sesek, 2013-05-23 13:00:58]

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:178:
messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
On 2013/05/23 01:02:56, Nico wrote:
> If the user cancels a swipe, does appkit animate back to amount of 0
> automatically? i.e. do you need to reset the frame to originalFrame_ or does
> that just work?

Yup! AppKit will run the animation back for us.

[dewittj, 2013-05-23 16:28:36]

lgtm

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:167: [window setAlphaValue:1.0 -
std::abs(amount)];
Is the linear reduction of alpha the most natural?  Should we experiment with
different rates of fadeout?

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:178:
messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
nit: spaces between comment markers and other text (unless this is a common ObjC
way)

[Robert Sesek, 2013-05-23 16:31:13]

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:167: [window setAlphaValue:1.0 -
std::abs(amount)];
On 2013/05/23 16:28:37, dewittj wrote:
> Is the linear reduction of alpha the most natural?  Should we experiment with
> different rates of fadeout?

This isn't actually linear. |amount| is done through some elastic graduation
provided by AppKit.

https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
ui/message_center/cocoa/popup_controller.mm:178:
messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
On 2013/05/23 16:28:37, dewittj wrote:
> nit: spaces between comment markers and other text (unless this is a common
ObjC
> way)

When doing this to "name" parameters, I think this is pretty common:

https://code.google.com/p/chromium/codesearch#search/&q==%5C*/&sq=package:chr...

[dewittj, 2013-05-23 16:34:36]

On 2013/05/23 16:31:13, rsesek wrote:
>
https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
> File ui/message_center/cocoa/popup_controller.mm (right):
> 
>
https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
> ui/message_center/cocoa/popup_controller.mm:167: [window setAlphaValue:1.0 -
> std::abs(amount)];
> On 2013/05/23 16:28:37, dewittj wrote:
> > Is the linear reduction of alpha the most natural?  Should we experiment
with
> > different rates of fadeout?
> 
> This isn't actually linear. |amount| is done through some elastic graduation
> provided by AppKit.
> 
>
https://codereview.chromium.org/15757005/diff/1/ui/message_center/cocoa/popup...
> ui/message_center/cocoa/popup_controller.mm:178:
> messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
> On 2013/05/23 16:28:37, dewittj wrote:
> > nit: spaces between comment markers and other text (unless this is a common
> ObjC
> > way)
> 
> When doing this to "name" parameters, I think this is pretty common:
> 
>
https://code.google.com/p/chromium/codesearch#search/&q==%255C*/&sq=package:c...

ok, consider me educated!

[commit-bot: I haz the power, 2013-05-23 16:35:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/15757005/1

[commit-bot: I haz the power, 2013-05-23 21:34:02]

Change committed as 201888