Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575653002: [Extensions] Small cleanup of extension_install_prompt.* (Closed)

Created:
4 years, 11 months ago by Devlin
Modified:
4 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Small cleanup of extension_install_prompt.* BUG=567839 Committed: https://crrev.com/3fe4bd3e8f314aa07ab36262e2480e1ce56d7097 Cr-Commit-Position: refs/heads/master@{#368925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/extensions/extension_install_prompt.h View 5 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/external_install_error.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
An easy one. :)
4 years, 11 months ago (2016-01-11 22:39:45 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 11 months ago (2016-01-12 17:08:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575653002/1
4 years, 11 months ago (2016-01-12 17:43:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 18:45:48 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 18:47:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fe4bd3e8f314aa07ab36262e2480e1ce56d7097
Cr-Commit-Position: refs/heads/master@{#368925}

Powered by Google App Engine
This is Rietveld 408576698