Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2963)

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix
Patch Set: Address nit. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
index 747e2e3bafee167ea706eca7193cde039236e2ed..64847ba680f66d528625ffafd7e2d6756f17c3e6 100644
--- a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
@@ -31,8 +31,8 @@ TEST(PermissionMenuModelTest, TestDefault) {
permission.type = CONTENT_SETTINGS_TYPE_COOKIES;
permission.setting = CONTENT_SETTING_ALLOW;
permission.default_setting = CONTENT_SETTING_ALLOW;
- PermissionMenuModel model(
- GURL("http://www.google.com"), permission, callback.callback());
+ PermissionMenuModel model(GURL("http://www.google.com"), permission,
+ false /* is_incognito */, callback.callback());
EXPECT_EQ(3, model.GetItemCount());
}
@@ -45,8 +45,8 @@ TEST(PermissionMenuModelTest, TestDefaultMediaHttp) {
permission.type = type;
permission.setting = CONTENT_SETTING_ALLOW;
permission.default_setting = CONTENT_SETTING_ALLOW;
- PermissionMenuModel model(
- GURL("http://www.google.com"), permission, callback.callback());
+ PermissionMenuModel model(GURL("http://www.google.com"), permission,
+ false /* is_incognito */, callback.callback());
EXPECT_EQ(2, model.GetItemCount());
}
}
@@ -66,6 +66,7 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {
permission.setting = CONTENT_SETTING_ASK;
permission.default_setting = CONTENT_SETTING_ASK;
PermissionMenuModel fullscreen_model(GURL("file:///test.html"), permission,
+ false /* is_incognito */,
callback.callback());
EXPECT_EQ(1, fullscreen_model.GetItemCount());
EXPECT_EQ(
@@ -74,6 +75,7 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {
permission.type = CONTENT_SETTINGS_TYPE_MOUSELOCK;
PermissionMenuModel mouselock_model(GURL("file:///test.html"), permission,
+ false /* is_incognito */,
callback.callback());
EXPECT_EQ(1, mouselock_model.GetItemCount());
EXPECT_EQ(

Powered by Google App Engine
This is Rietveld 408576698