chrome/browser/ui/website_settings/permission_menu_model_unittest.cc - Issue 1575623002: Disable Web Notifications in Incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix

Patch Set: Refactored to avoid changes to PermissionContextBase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_permission_context.cc ('K') | « chrome/browser/ui/website_settings/permission_menu_model.cc ('k') | components/content_settings/core/browser/content_settings_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

diff --git a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

index 747e2e3bafee167ea706eca7193cde039236e2ed..64847ba680f66d528625ffafd7e2d6756f17c3e6 100644

--- a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

+++ b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

@@ -31,8 +31,8 @@ TEST(PermissionMenuModelTest, TestDefault) {

permission.type = CONTENT_SETTINGS_TYPE_COOKIES;

permission.setting = CONTENT_SETTING_ALLOW;

permission.default_setting = CONTENT_SETTING_ALLOW;

- PermissionMenuModel model(

- GURL("http://www.google.com"), permission, callback.callback());

+ PermissionMenuModel model(GURL("http://www.google.com"), permission,

+ false /* is_incognito */, callback.callback());

EXPECT_EQ(3, model.GetItemCount());

}

@@ -45,8 +45,8 @@ TEST(PermissionMenuModelTest, TestDefaultMediaHttp) {

permission.type = type;

permission.setting = CONTENT_SETTING_ALLOW;

permission.default_setting = CONTENT_SETTING_ALLOW;

- PermissionMenuModel model(

- GURL("http://www.google.com"), permission, callback.callback());

+ PermissionMenuModel model(GURL("http://www.google.com"), permission,

+ false /* is_incognito */, callback.callback());

EXPECT_EQ(2, model.GetItemCount());

}

@@ -66,6 +66,7 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {

permission.setting = CONTENT_SETTING_ASK;

permission.default_setting = CONTENT_SETTING_ASK;

PermissionMenuModel fullscreen_model(GURL("file:///test.html"), permission,

+ false /* is_incognito */,

callback.callback());

EXPECT_EQ(1, fullscreen_model.GetItemCount());

EXPECT_EQ(

@@ -74,6 +75,7 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {

permission.type = CONTENT_SETTINGS_TYPE_MOUSELOCK;

PermissionMenuModel mouselock_model(GURL("file:///test.html"), permission,

+ false /* is_incognito */,

callback.callback());

EXPECT_EQ(1, mouselock_model.GetItemCount());

EXPECT_EQ(