Chromium Code Reviews| Index: components/content_settings/core/browser/content_settings_info.h |
| diff --git a/components/content_settings/core/browser/content_settings_info.h b/components/content_settings/core/browser/content_settings_info.h |
| index b7018dfff5209db38fb0b1c92d812f998764edfe..c18452f338861317f0852d522073fd4ac7102ec8 100644 |
| --- a/components/content_settings/core/browser/content_settings_info.h |
| +++ b/components/content_settings/core/browser/content_settings_info.h |
| @@ -26,7 +26,15 @@ class ContentSettingsInfo { |
| // Content setting will only partially inherit from regular to incognito |
| // profiles: BLOCK will inherit as usual, but ALLOW will become ASK. |
| // This is unusual, so seek privacy review before using this. |
| - INHERIT_IN_INCOGNITO_EXCEPT_ALLOW |
| + INHERIT_IN_INCOGNITO_EXCEPT_ALLOW, |
| + |
| + // Content setting is always denied in incognito. However, to prevent sites |
| + // from using this setting to detect whether incognito mode is active, this |
| + // acts like INHERIT_IN_INCOGNITO_EXCEPT_ALLOW initially, and only denies |
| + // the permission once it is requested, after a random time delay that |
| + // simulates a user clicking a bubble/infobar. |
| + // This is unusual, so seek privacy review before using this. |
|
raymes
2016/01/11 00:41:11
nit: fill previous line (or new paragraph)
johnme
2016/01/11 13:53:52
Done.
|
| + DENY_IN_INCOGNITO_AFTER_DELAY |
| }; |
| // This object does not take ownership of |website_settings_info|. |