Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575593002: dart2js cps: Name labels uniquely within each method, not globally. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Name labels uniquely within each method, not globally. Apart from a slight code size benefit, this should also make the diff more stable. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/afd7a91da4f4714402ca7cbb5f6498b9ffd56f03

Patch Set 1 #

Patch Set 2 : Typo #

Total comments: 2

Patch Set 3 : Use putIfAbsent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 4 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
4 years, 11 months ago (2016-01-08 21:09:03 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/1575593002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/1575593002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode675 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:675: String name = labelNames[label]; You could use putIfAbsent ...
4 years, 11 months ago (2016-01-08 22:05:47 UTC) #3
asgerf
https://codereview.chromium.org/1575593002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/1575593002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode675 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:675: String name = labelNames[label]; On 2016/01/08 22:05:47, Kevin Millikin ...
4 years, 11 months ago (2016-01-08 22:13:29 UTC) #4
asgerf
4 years, 11 months ago (2016-01-08 22:15:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
afd7a91da4f4714402ca7cbb5f6498b9ffd56f03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698