Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: components/nacl/renderer/plugin/pnacl_coordinator.cc

Issue 1575573002: PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/plugin/pnacl_coordinator.cc
diff --git a/components/nacl/renderer/plugin/pnacl_coordinator.cc b/components/nacl/renderer/plugin/pnacl_coordinator.cc
index f80a465bcf084e2e066714374df91bdece8bdd81..be38eba551d82d2035e1771b60fbdd1cd70de59e 100644
--- a/components/nacl/renderer/plugin/pnacl_coordinator.cc
+++ b/components/nacl/renderer/plugin/pnacl_coordinator.cc
@@ -270,7 +270,7 @@ void PnaclCoordinator::BitcodeStreamCacheHit(PP_FileHandle handle) {
}
temp_nexe_file_.reset(new TempFile(plugin_, handle));
// Open it for reading as the cached nexe file.
- NexeReadDidOpen(temp_nexe_file_->Open(false));
+ NexeReadDidOpen(temp_nexe_file_->CheckValidity());
}
void PnaclCoordinator::BitcodeStreamCacheMiss(int64_t expected_pexe_size,
@@ -308,7 +308,7 @@ void PnaclCoordinator::BitcodeStreamCacheMiss(int64_t expected_pexe_size,
PP_FileHandle obj_handle =
plugin_->nacl_interface()->CreateTemporaryFile(plugin_->pp_instance());
nacl::scoped_ptr<TempFile> temp_file(new TempFile(plugin_, obj_handle));
- int32_t pp_error = temp_file->Open(true);
+ int32_t pp_error = temp_file->CheckValidity();
if (pp_error != PP_OK) {
ReportPpapiError(PP_NACL_ERROR_PNACL_CREATE_TEMP,
pp_error,
@@ -323,7 +323,7 @@ void PnaclCoordinator::BitcodeStreamCacheMiss(int64_t expected_pexe_size,
temp_nexe_file_.reset(new TempFile(plugin_, nexe_handle));
// Open the nexe file for connecting ld and sel_ldr.
// Start translation when done with this last step of setup!
- int32_t pp_error = temp_nexe_file_->Open(true);
+ int32_t pp_error = temp_nexe_file_->CheckValidity();
if (pp_error != PP_OK) {
ReportNonPpapiError(
PP_NACL_ERROR_PNACL_CREATE_TEMP,
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/temporary_file.h » ('j') | components/nacl/renderer/plugin/temporary_file.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698