PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/770a614de349b5ec5dc0c20308ff745e215e1d8c
Cr-Commit-Position: refs/heads/master@{#368467}

[Mark Seaborn, 2016-01-08 20:23:19]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 20:24:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575573002/1

[Mark Seaborn, 2016-01-08 21:28:45]

Description was changed from

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile
==========

to

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used since we're not
using SRPC any more.

Open() has the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[Mark Seaborn, 2016-01-08 21:28:45]

mseaborn@chromium.org changed reviewers:
+ bbudge@chromium.org

[Mark Seaborn, 2016-01-08 21:29:15]

Description was changed from

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used since we're not
using SRPC any more.

Open() has the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() has the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[Mark Seaborn, 2016-01-08 21:29:34]

Description was changed from

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() has the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[bbudge, 2016-01-08 21:37:06]

LGTM w/1 suggestion

https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
File components/nacl/renderer/plugin/temporary_file.cc (right):

https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
components/nacl/renderer/plugin/temporary_file.cc:27: return PP_OK;
nit: you can simplify this a bit by using PP_FromBool (in pp_bool.h).

[commit-bot: I haz the power, 2016-01-08 21:48:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 21:48:08]

Dry run: This issue passed the CQ dry run.

[Mark Seaborn, 2016-01-08 22:02:27]

https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
File components/nacl/renderer/plugin/temporary_file.cc (right):

https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
components/nacl/renderer/plugin/temporary_file.cc:27: return PP_OK;
On 2016/01/08 21:37:06, bbudge wrote:
> nit: you can simplify this a bit by using PP_FromBool (in pp_bool.h).

Doesn't that convert to a PP_Bool rather than to a PPAPI error value?

I should be able to simplify TempFile further by just replacing it with a
base::File.  I can do that as a later change...

[bbudge, 2016-01-08 22:23:23]

On 2016/01/08 22:02:27, Mark Seaborn wrote:
>
https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
> File components/nacl/renderer/plugin/temporary_file.cc (right):
> 
>
https://codereview.chromium.org/1575573002/diff/1/components/nacl/renderer/pl...
> components/nacl/renderer/plugin/temporary_file.cc:27: return PP_OK;
> On 2016/01/08 21:37:06, bbudge wrote:
> > nit: you can simplify this a bit by using PP_FromBool (in pp_bool.h).
> 
> Doesn't that convert to a PP_Bool rather than to a PPAPI error value?
> 
> I should be able to simplify TempFile further by just replacing it with a
> base::File.  I can do that as a later change...

Oops, you're right.

[Mark Seaborn, 2016-01-08 22:31:09]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-01-08 22:33:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575573002/1

[commit-bot: I haz the power, 2016-01-08 23:53:52]

Description was changed from

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[commit-bot: I haz the power, 2016-01-08 23:53:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-08 23:55:29]

Description was changed from

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFile

read_wrapper() and write_wrapper() are no longer used now that the
PNaCl code doesn't use SRPC.

Open() had the side effect of checking the validity of the
handle/descriptor before, so preserve that, but rename it to
CheckValidity() to clarify what it does.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/770a614de349b5ec5dc0c20308ff745e215e1d8c
Cr-Commit-Position: refs/heads/master@{#368467}
==========

[commit-bot: I haz the power, 2016-01-08 23:55:30]

Patchset 1 (id:??) landed as
https://crrev.com/770a614de349b5ec5dc0c20308ff745e215e1d8c
Cr-Commit-Position: refs/heads/master@{#368467}